Skip to content

[Fix][Tests] TP param used in tests unconditionally #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

[Fix][Tests] TP param used in tests unconditionally #315

merged 1 commit into from
Jul 17, 2025

Conversation

@rafvasq
Copy link
Collaborator

@rafvasq rafvasq commented Jul 16, 2025

Description

--tensor-parallel-size and tp_size flag being used regardless of the the block checking if tp_size exists.

@rafvasq
fix tp param usage
0d1369e 
Signed-off-by: Rafael Vasquez <[email protected]>
@github-actions
Copy link

github-actions bot commented Jul 16, 2025

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@rafvasq rafvasq changed the title [Bug] Fix tp param in conftest [Bug][Tests] Fix tp param in conftest Jul 16, 2025
@rafvasq rafvasq changed the title [Bug][Tests] Fix tp param in conftest [Fix][Tests] TP param used in tests unconditionally Jul 16, 2025
@rafvasq rafvasq enabled auto-merge (squash) July 16, 2025 23:12
@github-actions github-actions bot added the ready label Jul 16, 2025
yannicks1
yannicks1 approved these changes Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@yannicks1 yannicks1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching that.

@rafvasq rafvasq merged commit 9d21620 into vllm-project:main Jul 17, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yannicks1 yannicks1 yannicks1 approved these changes

@prashantgupta24 prashantgupta24 Awaiting requested review from prashantgupta24 prashantgupta24 is a code owner

@sducouedic sducouedic Awaiting requested review from sducouedic sducouedic is a code owner

Assignees

No one assigned

Labels

ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rafvasq @yannicks1